Clarified parameterization of AR1 model in AR notebook

[fonnesbeck]

The AR notebook conflates the precision and variance in the description and data simulation steps. I've updated the notebook to make it consistent.

Closes #4059

[review-notebook-app]

Check out this pull request on 

Review Jupyter notebook visual diffs & provide feedback on notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

Merging #4063 (87adbc7) into master (f732a01) will decrease coverage by 2.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4063      +/-   ##
==========================================
- Coverage   88.91%   86.83%   -2.08%     
==========================================
  Files          89       88       -1     
  Lines       14429    14165     -264     
==========================================
- Hits        12829    12300     -529     
- Misses       1600     1865     +265     

Impacted Files	Coverage Δ
pymc3/distributions/discrete.py	74.65% <0.00%> (-22.56%)	⬇️
pymc3/distributions/timeseries.py	71.93% <0.00%> (-13.87%)	⬇️
pymc3/distributions/continuous.py	80.09% <0.00%> (-13.07%)	⬇️
pymc3/distributions/multivariate.py	78.17% <0.00%> (-3.03%)	⬇️
pymc3/distributions/mixture.py	86.48% <0.00%> (-2.87%)	⬇️
pymc3/tests/models.py	85.95% <0.00%> (-1.82%)	⬇️
pymc3/tuning/starting.py	80.91% <0.00%> (-0.91%)	⬇️
pymc3/tuning/scaling.py	57.40% <0.00%> (-0.78%)	⬇️
pymc3/util.py	93.75% <0.00%> (-0.64%)	⬇️
pymc3/model.py	88.95% <0.00%> (-0.39%)	⬇️
... and 69 more

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2020-08-23T17:21:42Z
----------------------------------------------------------------

nice to have the version output.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2020-08-23T17:21:43Z
----------------------------------------------------------------

How does it sample with default tuning?

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2020-08-23T17:21:44Z
----------------------------------------------------------------

also here good to have output

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

AlexAndorra commented on 2020-08-24T11:13:57Z
----------------------------------------------------------------

This small text needs to be upated too

[michaelosthege]

I just made the change requested in the review and removed the print of the PyMC3 version, because that's already covered by the watermark at the end of the notebook.

Hope this pushes it over the finish line?

[twiecki]

@michaelosthege LGTM but merge conflict :-/