Skip to content

Delete unreachable code (issue 4098) #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

rpgoldman
Copy link
Contributor

get_context() had unnecessarily complex code, a legacy from an earlier stage of its development.

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #4100 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4100   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files          88       88           
  Lines       13865    13862    -3     
=======================================
- Hits        12268    12266    -2     
+ Misses       1597     1596    -1     
Impacted Files Coverage Δ
pymc3/model.py 88.00% <100.00%> (+0.07%) ⬆️

@rpgoldman rpgoldman changed the title WIP: Delete unreachable code (issue 4098) Delete unreachable code (issue 4098) Sep 13, 2020
@rpgoldman
Copy link
Contributor Author

Ready for review and merge

@ColCarroll ColCarroll merged commit 632305d into pymc-devs:master Sep 14, 2020
@ColCarroll
Copy link
Member

Thanks, @rpgoldman!

@rpgoldman rpgoldman deleted the iss4098 branch September 14, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants