Formatted Next 15 Files #4150
Formatted Next 15 Files #4150
Conversation
|
Nice, thanks, there's just a couple of places where |
|
@MarcoGorelli Sir in the file model.py total 4 occurrence's of |
Codecov Report
@@ Coverage Diff @@
## master #4150 +/- ##
==========================================
+ Coverage 88.74% 88.75% +0.01%
==========================================
Files 89 89
Lines 14024 14039 +15
==========================================
+ Hits 12446 12461 +15
Misses 1578 1578
|
There was a problem hiding this comment.
Thanks @Yash1256 ! Almost all good: just one place where Black formatting should be disabled to preserve readability (see my comment below)
pymc3/tests/test_examples.py
Outdated
| 0, 1, 0, 1, 0, 0, 0, 2, 1, 0, 0, 0, 1, 1, 0, 2, | ||
| 3, 3, 1, 1, 2, 1, 1, 1, 1, 2, 4, 2, 0, 0, 1, 4, | ||
| 0, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 1]) | ||
| disasters_data = np.array( |
There was a problem hiding this comment.
Please use # fmt: off here, to disable (and then re-enable) Black formatting -- see step 3 of the style guide
There was a problem hiding this comment.
@Yash1256 thanks for updating - I think you'll want to checkout this file to how it is on upstream/master before putting # fmt: off and running black again.
Workflow would be something like
git fetch upstream --prune
git checkout upstream/master -- pymc3/tests/test_examples.py
<add in #fmt: off and #fmt: on as suggested by Alex>
black pymc3/tests/test_examples.py
git add -u
git commit -m <some descriptive message lol>
git push -u origin HEAD
There was a problem hiding this comment.
Please review @AlexAndorra @MarcoGorelli
Changes Done Sir used # fmt: off before and # fmt:on after the array
Changes updated
Issue #4109 Applying Formatting on Next 15 Files