Skip to content

Update/Standardize nodebook: GLM-negative-binomial-regression #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

AmitKus
Copy link
Contributor

@AmitKus AmitKus commented Oct 6, 2020

  1. Fix KeyError
  2. Update the notebook based on style guide

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

  • what are the (breaking) changes that this PR makes?
  • important background, or details about the implementation
  • are the changes—especially new features—covered by tests and docstrings?
  • consider adding/updating relevant example notebooks
  • right before it's ready to merge, mention the PR in the RELEASE-NOTES.md

2. Update the notebook based on style guide
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #4158 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4158   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files          89       89           
  Lines       14039    14039           
=======================================
+ Hits        12460    12461    +1     
+ Misses       1579     1578    -1     
Impacted Files Coverage Δ
pymc3/distributions/continuous.py 92.93% <0.00%> (+0.11%) ⬆️

Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @AmitKus !

@AlexAndorra AlexAndorra merged commit 7429b4b into pymc-devs:master Oct 6, 2020
@AmitKus AmitKus deleted the GLM-negative-binom branch October 10, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants