Check notebooks are in table of contents, bump some hooks #4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
check-toc
branch
from
21d1c9c to
5f222b3
Compare
MarcoGorelli
force-pushed
the
check-toc
branch
from
1a048f7 to
444acc8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4197 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 89 89
Lines 14429 14429
=======================================
Hits 12829 12829
Misses 1600 1600 |
twiecki
approved these changes
Oct 28, 2020
|
This looks super helpful @MarcoGorelli. I think the categories are fine. |
AlexAndorra
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #4193
also bumping a few other hooks (I'll remove the bump from #4181)
I wasn't sure where to put the notebook "factor_analysis" - any suggestions?
A few others were missing too, e.g. @ferrine 's circular kernel