CI simplify check-watermark #4200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4200 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 89 89
Lines 14429 14429
=======================================
Hits 12829 12829
Misses 1600 1600 |
AlexAndorra
requested changes
Oct 29, 2020
There was a problem hiding this comment.
Super nice, thanks @MarcoGorelli !
Just one thing before merging: can you add the minimal pre-commit version requirement to environment.yml too please? It's useful for people using conda 😉
michaelosthege
approved these changes
Oct 30, 2020
MarcoGorelli
commented
Oct 30, 2020
michaelosthege
approved these changes
Oct 30, 2020
AlexAndorra
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a PR in to pre-commit to add a
--negateflag topygrep, usingcheck-watermarkas an example use-case 🎉So...let's use it? It means not having to maintain an extra
scripts/check_watermark.pyfile, which can only be a good thingpygrepis a Python implementation of grep, so is cross-platform--negatewill exit with code 1 if a pattern is not found (in this case, we want the watermark to be found in every notebook)--multilinemakes pygrep look through the entire file, rather than just line-by-line