-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Proposal] Track Submodule pymc-examples Git Fix #4375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Track Submodule pymc-examples Git Fix #4375
Conversation
* Configure .gitmodules to specify branch for submodule * closes pymc-devs#4357
Codecov Report
@@ Coverage Diff @@
## master #4375 +/- ##
=======================================
Coverage 87.95% 87.96%
=======================================
Files 88 88
Lines 14493 14501 +8
=======================================
+ Hits 12748 12756 +8
Misses 1745 1745
|
.gitmodules
Outdated
@@ -1,3 +1,4 @@ | |||
[submodule "docs/source/pymc-examples"] | |||
path = docs/source/pymc-examples | |||
url = [email protected]:pymc-devs/pymc-examples.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this doesn't work for you because you don't have ssh keys set up. Perhaps we can change this line to
url = git@github.com:pymc-devs/pymc-examples.git | |
url = https://github.com/pymc-devs/pymc-examples.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see @MarcoGorelli. Thanks!
Did that. Following, I did a git submodule sync
, based on this article.
Process now looked like:
0. Edit the .gitmodules
file
git submodule sync
git submodule update --remote
git checkout main
(on the submodule)- Went to parent module, and committed changes
* Configure .gitmodules to specify branch for submodule * closes pymc-devs#4357
* Updated .gitattributes file * git submodule sync * switch branch * go to parent module, and commit
Update made, well I hope. Before going into recommended updates from the original suggested article, here, I did the following: Process now looked like:
Oddly, the submodule is pointed to a commit SHA, and not That being said, going forward, updating that submodule maaaaaay look like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks right
Can you just update build_and_deploy_docs.sh as well?
Sounds great! Changed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CloudChaoszero
cc @ColCarroll
Overview
Proposed 🤞 fix to track submodule pymc-examples to the main branch.
(potentially) closes #4357
However, there are some notes... ⬇️
Notes
git submodule update --remote
You can see this error to align commit to

main
branch here