Remove uses of deprecated aesara.tensor.nlinalg.diag #4501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
remove-use-of-deprecated-diag
branch
from
b3c058f to
82454e8
Compare
brandonwillard
force-pushed
the
remove-use-of-deprecated-diag
branch
from
82454e8 to
b961ab0
Compare
This was referenced Mar 5, 2021
|
I don't understand how this fixes the issue. You're just changing an import of |
twiecki
approved these changes
Mar 5, 2021
|
@brandonwillard My bad, I thought this was a PR to aesara. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes calls to
aesara.tensor.nlinalg.diagtoaesara.tensor.basic.diag. This should be used in combination with the most recent Aesara code; otherwise, there will be issues with JAX conversions ofAllocDiagOps (see pymc-devs/pytensor#313).