Skip to content

Remove nonexistent attribute from __all__ list #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2021
Merged

Remove nonexistent attribute from __all__ list #4627

merged 1 commit into from
Apr 11, 2021

Conversation

michaelosthege
Copy link
Member

The pylint pre-commit job constantly complains about this..

@michaelosthege michaelosthege added this to the vNext (4.0.0) milestone Apr 10, 2021
ricardoV94
ricardoV94 approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@ricardoV94 ricardoV94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue? Duplicated with arviz?

@michaelosthege
Copy link
Member Author

What was the issue? Duplicated with arviz?

The function was an alias that was deprecated and removed already - just it's string in __all__ was forgotten.

@michaelosthege michaelosthege merged commit 0a51adf into v4 Apr 11, 2021
@michaelosthege michaelosthege deleted the fix-plots-all branch April 11, 2021 01:04
twiecki pushed a commit that referenced this pull request Jun 5, 2021
@michaelosthege @twiecki
Remove nonexistent attribute from __all__ list (#4627)
9636408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 approved these changes

Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
v4.0.0b1 (vNext)
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelosthege @ricardoV94