Fixing np.bool Depreciation warnings: 3 files #4673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 8, 2021 08:18
This reverts commit 685a065.
|
Thanks for taking this on! The warning says to just replace it with |
|
Oh, I see, I assumed that numpy data types were preferred because of the other key/value pairs in |
|
Seems like |
|
Fixed! (+ other files not mentioned in the error shown in the original issue) |
michaelosthege
approved these changes
May 2, 2021
twiecki
approved these changes
May 3, 2021
|
Thanks @larryshamalama and congrats on your first PR! 🥳 |
|
Thank you very much! 🙂 |
twiecki
pushed a commit
that referenced
this pull request
Jun 5, 2021
* 🐢 Fixed documentation * 🐢 Minor fix on top of grammar fixed in docs * Weibull RandomVariable refactoring: an example * Revert "Weibull RandomVariable refactoring: an example" This reverts commit 685a065. * Fixing np.bool depreciation warnings: 3 files * Changed np.bool_ to bool (+ fixed other places)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue 4670
Not sure where the test warnings come from. I changed "np.bool" to "np.bool_" in 3 files as the warning suggests.