Skip to content

Remove GLM submodule in v4 #4682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2021
Merged

Remove GLM submodule in v4 #4682

merged 3 commits into from
May 11, 2021

Conversation

farhanreynaldo
Copy link
Contributor

This PR closes #4681, which remove GLM submodule and its test, in favor to Bambi.

@ricardoV94
Copy link
Member

Does something need to be changed in the docs templates?

@farhanreynaldo
Copy link
Contributor Author

Does something need to be changed in the docs templates?

Should I remove the docs/source/api/glm.rst and the glm line in docs/source/api.rst?

@OriolAbril
Copy link
Member

Should I remove the docs/source/api/glm.rst and the glm line in docs/source/api.rst?

I would do something like we do with ArviZ, not completely removing this from the documentation but instead leave only 1-2 sentences and a link to bambi. Example from stats "module": https://docs.pymc.io/api/stats.html, here there would be no aliases, but it could still be useful to have the link to bambi there somehow like we do in the first paragraph in stats.

twiecki
twiecki previously approved these changes May 10, 2021
@twiecki
Copy link
Member

twiecki commented May 10, 2021

Definitely needs a line in the release notes for v4.

@farhanreynaldo
Copy link
Contributor Author

farhanreynaldo commented May 10, 2021

Definitely needs a line in the release notes for v4.

Should I add something like this here?

## PyMC3 vNext (4.0.0)
### Breaking Changes
- ⚠ Theano-PyMC has been replaced with Aesara, so all external references to `theano`, `tt`, and `pymc3.theanof` need to be replaced with `aesara`, `at`, and `pymc3.aesaraf` (see [4471](https://github.com/pymc-devs/pymc3/pull/4471)).
- ArviZ `plots` and `stats` *wrappers* were removed. The functions are now just available by their original names (see [#4549](https://github.com/pymc-devs/pymc3/pull/4471) and `3.11.2` release notes).
- GLM submodule is now delegated to Bambi library [#4682](https://github.com/pymc-devs/pymc3/pull/4682)
- ...

I am not actually confidence with the sentence.

@twiecki
Copy link
Member

twiecki commented May 10, 2021

A bit clearer would be "The glm submodule has been removed, please use Bambi [link] instead."

@twiecki twiecki merged commit ad26d25 into pymc-devs:v4 May 11, 2021
@twiecki
Copy link
Member

twiecki commented May 11, 2021

Thanks @farhanreynaldo!

twiecki pushed a commit that referenced this pull request Jun 5, 2021
* remove GLM submodule and its test

* add glm reference to Bambi

* add GLM removal to release notes

Co-authored-by: Farhan Reynaldo <[email protected]>
@twiecki twiecki mentioned this pull request Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants