-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove GLM submodule in v4 #4682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does something need to be changed in the docs templates? |
Should I remove the |
I would do something like we do with ArviZ, not completely removing this from the documentation but instead leave only 1-2 sentences and a link to bambi. Example from stats "module": https://docs.pymc.io/api/stats.html, here there would be no aliases, but it could still be useful to have the link to bambi there somehow like we do in the first paragraph in stats. |
Definitely needs a line in the release notes for v4. |
Should I add something like this here?
I am not actually confidence with the sentence. |
A bit clearer would be "The glm submodule has been removed, please use Bambi [link] instead." |
Thanks @farhanreynaldo! |
* remove GLM submodule and its test * add glm reference to Bambi * add GLM removal to release notes Co-authored-by: Farhan Reynaldo <[email protected]>
This PR closes #4681, which remove GLM submodule and its test, in favor to Bambi.