Refactored pymc3_random_discrete to use histograms instead of raw counts #4840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Jul 4, 2021
| p = 1.0 | ||
| else: | ||
| _, p = st.chisquare(k[:, 0], k[:, 1]) | ||
| _, p = st.chisquare(observed+1, expected+1) |
There was a problem hiding this comment.
If any of the bins are zero, the test fails (divide by zero). This was an easier solution than trying to te-generate the histogram with different bin sizes.
ricardoV94
reviewed
Jul 4, 2021
|
/pre-commit-run |
michaelosthege
previously approved these changes
Jul 4, 2021
michaelosthege
approved these changes
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failures due to new error checking in
scipy.stats.chisquare.Closes #4810