Skip to content

small edits in documentation and messages #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2021
Merged

small edits in documentation and messages #4921

merged 3 commits into from
Aug 13, 2021

Conversation

stestoll
Copy link
Contributor

This PR fixes a couple of typos and adds a few small improvements in the documentation.

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I just left a comment about the bad -> infinite change.

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes look good

@ricardoV94
Copy link
Member

ricardoV94 commented Aug 13, 2021

You seem to have a linting issue here: https://github.com/pymc-devs/pymc3/pull/4921/checks?check_run_id=3319910721#step:4:90

You can install pre-commit locally to format the files before pushing them here: https://github.com/pymc-devs/pymc3/wiki/PyMC3-Python-Code-Style

@stestoll
Copy link
Contributor Author

Oops. Sorry, I am new to this. Will fix.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #4921 (f0c4089) into main (6a75744) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4921      +/-   ##
==========================================
- Coverage   73.17%   73.14%   -0.04%     
==========================================
  Files          86       86              
  Lines       13868    13866       -2     
==========================================
- Hits        10148    10142       -6     
- Misses       3720     3724       +4     
Impacted Files Coverage Δ
pymc3/sampling.py 85.67% <ø> (ø)
pymc3/step_methods/arraystep.py 94.96% <ø> (ø)
pymc3/step_methods/hmc/base_hmc.py 91.05% <ø> (ø)
pymc3/step_methods/hmc/hmc.py 92.15% <ø> (ø)
pymc3/step_methods/hmc/nuts.py 97.50% <100.00%> (ø)
pymc3/backends/report.py 89.51% <0.00%> (-2.10%) ⬇️
pymc3/parallel_sampling.py 87.20% <0.00%> (-1.02%) ⬇️
pymc3/distributions/dist_math.py 88.29% <0.00%> (+0.92%) ⬆️

@stestoll
Copy link
Contributor Author

stestoll commented Aug 13, 2021

Why does Codecov report a coverage change in files that are unchanged by this PR? Is this just noise from non-deterministic tests?

@ricardoV94
Copy link
Member

ricardoV94 commented Aug 13, 2021

Why does Codecov report a coverage change in files that are unchanged by this PR? Is this just noise from non-deterministic tests?

The Codecov is impatient and starts reporting changes when some tests are still running. The final codecov should be fine though.

Otherwise, it might be a stochastic test that did not trigger a specific branch or something

@ricardoV94 ricardoV94 merged commit 6d2aa5d into pymc-devs:main Aug 13, 2021
@stestoll stestoll deleted the docedits branch August 13, 2021 09:41
@ricardoV94
Copy link
Member

Thank @stestoll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants