-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
small edits in documentation and messages #4921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I just left a comment about the bad
-> infinite
change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the changes look good
You seem to have a linting issue here: https://github.com/pymc-devs/pymc3/pull/4921/checks?check_run_id=3319910721#step:4:90 You can install |
Oops. Sorry, I am new to this. Will fix. |
Codecov Report
@@ Coverage Diff @@
## main #4921 +/- ##
==========================================
- Coverage 73.17% 73.14% -0.04%
==========================================
Files 86 86
Lines 13868 13866 -2
==========================================
- Hits 10148 10142 -6
- Misses 3720 3724 +4
|
Why does Codecov report a coverage change in files that are unchanged by this PR? Is this just noise from non-deterministic tests? |
The Codecov is impatient and starts reporting changes when some tests are still running. The final codecov should be fine though. Otherwise, it might be a stochastic test that did not trigger a specific branch or something |
Thank @stestoll |
This PR fixes a couple of typos and adds a few small improvements in the documentation.