Skip to content

Updated incorrect docstring and removed redundant logic in sampling.py #4979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

kc611
Copy link
Contributor

@kc611 kc611 commented Sep 3, 2021

Minor fixes based upon: #4912 (comment) and #4978 (comment)

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #4979 (b67b454) into main (9e15b20) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4979   +/-   ##
=======================================
  Coverage   74.13%   74.14%           
=======================================
  Files          86       86           
  Lines       13898    13911   +13     
=======================================
+ Hits        10303    10314   +11     
- Misses       3595     3597    +2     
Impacted Files Coverage Δ
pymc3/distributions/distribution.py 82.66% <ø> (ø)
pymc3/sampling.py 85.67% <100.00%> (-0.02%) ⬇️
pymc3/parallel_sampling.py 86.28% <0.00%> (-1.01%) ⬇️
pymc3/smc/smc.py 98.37% <0.00%> (-0.34%) ⬇️
pymc3/step_methods/metropolis.py 83.70% <0.00%> (+0.44%) ⬆️

@kc611 kc611 force-pushed the minor_docstring_imp branch from 199085b to 39ab7f6 Compare September 3, 2021 10:19
@kc611 kc611 force-pushed the minor_docstring_imp branch from 39ab7f6 to b67b454 Compare September 3, 2021 10:37
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoV94 ricardoV94 merged commit 61fa834 into pymc-devs:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants