Skip to content

GLM glossary term #5047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2021
Merged

GLM glossary term #5047

merged 3 commits into from
Oct 14, 2021

Conversation

mjhajharia
Copy link
Member

this PR adds GLM to glossary.md

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #5047 (ea47d09) into main (38a9e1f) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ea47d09 differs from pull request most recent head 6c69b63. Consider uploading reports for the commit 6c69b63 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5047      +/-   ##
==========================================
+ Coverage   57.86%   57.89%   +0.02%     
==========================================
  Files         130      130              
  Lines       24461    24461              
==========================================
+ Hits        14155    14162       +7     
+ Misses      10306    10299       -7     
Impacted Files Coverage Δ
pymc/parallel_sampling.py 86.33% <0.00%> (-1.00%) ⬇️
pymc/step_methods/hmc/base_hmc.py 90.32% <0.00%> (+0.80%) ⬆️
pymc/tests/test_sampling.py 97.29% <0.00%> (+1.28%) ⬆️

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side note, we should also choose glm or generalized linear models to use in tags: https://pymc-examples.readthedocs.io/en/latest/blog/tag/glm.html, https://pymc-examples.readthedocs.io/en/latest/blog/tag/generalized-linear-model.html

and I guess we could add links from glossary definitions to the correspondent tag in pymc-examples?

@@ -56,4 +56,12 @@ Posterior
Once you are satisfied with the model, posterior distribution can be summarized and interpreted. Common questions for the posterior include: intervals of defined boundaries, intervals of defined probability mass, and point estimates. When the posterior is very similar to the prior, the available data does not contain much information about a parameter of interest.

- For more on generating and interpreting the posterior samples, see Statistical Rethinking 2nd Edition By Richard McElreath, chapter 3.

Generalized Linear Model(GLM)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write generalized linear models and glm in different lines instead. Whatever we use as name in the glossary is what we have to use to reference it. Either or

{term}`glm`
{term}`generalized linear models`

is fine, but I'd rather not have to write both name and acronym every time.

@OriolAbril OriolAbril merged commit bf4e21e into pymc-devs:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants