Skip to content

Add dims to *Ordered probs variables when appropriate #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AustinRochford
Copy link
Member

Add dims to _probs RV for ordered distributions when appropriate.

Copy link
Member

@ColCarroll ColCarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a small repro test you wanted to add, that'd be great, but this looks fine as is.

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #5084 (7237947) into main (e03f5bf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5084      +/-   ##
==========================================
+ Coverage   75.10%   75.12%   +0.02%     
==========================================
  Files          87       87              
  Lines       14142    14142              
==========================================
+ Hits        10621    10624       +3     
+ Misses       3521     3518       -3     
Impacted Files Coverage Δ
pymc/distributions/discrete.py 98.01% <100.00%> (ø)
pymc/distributions/multivariate.py 71.42% <100.00%> (ø)
pymc/backends/report.py 91.60% <0.00%> (+2.09%) ⬆️

@AustinRochford AustinRochford merged commit 598dd9d into pymc-devs:main Oct 17, 2021
@AustinRochford AustinRochford deleted the ordered-logit-add-prob-dims branch October 17, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants