-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
execute notebooks when building docs #5314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #5314 +/- ##
==========================================
- Coverage 80.36% 79.08% -1.29%
==========================================
Files 89 88 -1
Lines 14808 14435 -373
==========================================
- Hits 11901 11416 -485
- Misses 2907 3019 +112
|
This should fix itself once we unpin/upgrade aesara and/or pin numpy |
c8ff9d0
to
29e71f6
Compare
Aesara doesn't seem to work on readthedocs, even with the numpy pin, now it is installed and imported but can't compile models: https://pymc--5314.org.readthedocs.build/en/5314/learn/examples/pymc_overview.html#model-specification. We'll need to use something like: https://github.com/dfm/rtds-action which I don't have time to set up right now, unless someone can try this nowish we should move it to beta3 milestone and release beta2 |
8d7b32a
to
ffce07d
Compare
Auto execution working now: https://pymc--5314.org.readthedocs.build/en/5314/learn/examples/GLM_linear.html is now running on beta2 and bambi 0.7 |
This will ensure that the core notebooks in this repo are correctly versioned along with
the rest of the documentation. As they are only a handful of small and fast notebooks
it doesn't take long, but we should keep in mind to not add long/slow notebooks here
and keep them on pymc-examples.
I think we should wait to merge this until we have merged the updated notebooks in #5369