Skip to content

execute notebooks when building docs #5314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 21, 2022
Merged

execute notebooks when building docs #5314

merged 4 commits into from
Jan 21, 2022

Conversation

OriolAbril
Copy link
Member

This will ensure that the core notebooks in this repo are correctly versioned along with
the rest of the documentation. As they are only a handful of small and fast notebooks
it doesn't take long, but we should keep in mind to not add long/slow notebooks here
and keep them on pymc-examples.

I think we should wait to merge this until we have merged the updated notebooks in #5369

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #5314 (c8ff9d0) into main (d52655d) will decrease coverage by 1.28%.
The diff coverage is n/a.

❗ Current head c8ff9d0 differs from pull request most recent head ffce07d. Consider uploading reports for the commit ffce07d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5314      +/-   ##
==========================================
- Coverage   80.36%   79.08%   -1.29%     
==========================================
  Files          89       88       -1     
  Lines       14808    14435     -373     
==========================================
- Hits        11901    11416     -485     
- Misses       2907     3019     +112     
Impacted Files Coverage Δ
pymc/sampling_jax.py 0.00% <0.00%> (-97.46%) ⬇️
pymc/variational/stein.py 38.00% <0.00%> (-10.34%) ⬇️
pymc/tuning/starting.py 83.19% <0.00%> (-9.37%) ⬇️
pymc/variational/approximations.py 30.06% <0.00%> (-6.25%) ⬇️
pymc/variational/opvi.py 30.29% <0.00%> (-5.93%) ⬇️
pymc/variational/flows.py 31.55% <0.00%> (-5.24%) ⬇️
pymc/__init__.py 96.07% <0.00%> (-3.93%) ⬇️
pymc/model.py 83.55% <0.00%> (-2.38%) ⬇️
pymc/tests/conftest.py 90.47% <0.00%> (-1.53%) ⬇️
pymc/distributions/mixture.py 19.76% <0.00%> (-1.42%) ⬇️
... and 41 more

@OriolAbril OriolAbril added this to the v4.0.0b2 milestone Jan 7, 2022
@OriolAbril
Copy link
Member Author

This should fix itself once we unpin/upgrade aesara and/or pin numpy

@OriolAbril
Copy link
Member Author

Aesara doesn't seem to work on readthedocs, even with the numpy pin, now it is installed and imported but can't compile models: https://pymc--5314.org.readthedocs.build/en/5314/learn/examples/pymc_overview.html#model-specification. We'll need to use something like: https://github.com/dfm/rtds-action which I don't have time to set up right now, unless someone can try this nowish we should move it to beta3 milestone and release beta2

@michaelosthege michaelosthege modified the milestones: v4.0.0b2, v4.0.0b3 Jan 12, 2022
@michaelosthege michaelosthege marked this pull request as draft January 13, 2022 14:37
@OriolAbril
Copy link
Member Author

Auto execution working now: https://pymc--5314.org.readthedocs.build/en/5314/learn/examples/GLM_linear.html is now running on beta2 and bambi 0.7

@OriolAbril OriolAbril marked this pull request as ready for review January 18, 2022 04:04
@OriolAbril OriolAbril merged commit be3f77e into main Jan 21, 2022
@OriolAbril OriolAbril deleted the execute_notebooks branch January 21, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants