Skip to content

Infer GRW steps from shape #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 69 commits into from
Closed

Conversation

canyon289
Copy link
Member

@ricardoV94 Thanks for adding this commit to the grw branch.

I've moved it to another PR solely for reasons of my own learning. and not because I disagree with the changes or think they shouldn't be merged.. Once the GRW pr is good enough as is I'd like to go through and "relearn" everything about it so I can make sure I understood that scope. I'll then do the same for this logic too!

Hopefully that makes sense

@canyon289 canyon289 changed the title Infer steps from shape Infer GRW steps from shape Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #5541 (47571a7) into grw (2171790) will increase coverage by 0.09%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              grw    #5541      +/-   ##
==========================================
+ Coverage   86.36%   86.46%   +0.09%     
==========================================
  Files          81       81              
  Lines       14261    14437     +176     
==========================================
+ Hits        12317    12483     +166     
- Misses       1944     1954      +10     
Impacted Files Coverage Δ
pymc/distributions/timeseries.py 27.93% <28.57%> (-0.64%) ⬇️
pymc/sampling_jax.py 96.89% <0.00%> (-1.53%) ⬇️
pymc/parallel_sampling.py 86.71% <0.00%> (-1.00%) ⬇️
pymc/distributions/discrete.py 99.66% <0.00%> (-0.11%) ⬇️
pymc/model.py 84.82% <0.00%> (ø)

@canyon289
Copy link
Member Author

Ill come back this this one now that GRW is merged
#5298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants