Skip to content

Improve issue templates #6345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Conversation

ricardoV94
Copy link
Member

Made some changes to the template issues

Changes and motivation

  1. No point in forcing a link to a discussion in the feature request issue. We can easily convert an issue to a discussion or vice-versa ourselves
  2. Not requiring a link to existing documentation. If the user is asking for new documentation, it's not relevant. The less annoying the better I would say.
  3. Remove installation issue template. I think it's fine to direct users to discourse for this? If it's actually a problem it would become a bug issue later
  4. Add free-form issue for developers

Docs / Maintenance

  • Improve template issues

@ricardoV94 ricardoV94 added maintenance no releasenotes Skipped in automatic release notes generation labels Nov 29, 2022
@ricardoV94 ricardoV94 force-pushed the improve_issue_templates branch from f30be1f to ee3bc2c Compare November 29, 2022 08:12
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #6345 (f30be1f) into main (3ff4e7a) will decrease coverage by 3.29%.
The diff coverage is 100.00%.

❗ Current head f30be1f differs from pull request most recent head 9e88e26. Consider uploading reports for the commit 9e88e26 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6345      +/-   ##
==========================================
- Coverage   94.15%   90.85%   -3.30%     
==========================================
  Files         132      132              
  Lines       26726    26730       +4     
==========================================
- Hits        25163    24285     -878     
- Misses       1563     2445     +882     
Impacted Files Coverage Δ
pymc/variational/opvi.py 75.27% <ø> (-11.81%) ⬇️
pymc/model.py 89.84% <100.00%> (-0.09%) ⬇️
pymc/tests/variational/test_opvi.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/variational/test_callbacks.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/variational/test_approximations.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/variational/test_inference.py 0.00% <0.00%> (-99.03%) ⬇️
pymc/variational/test_functions.py 38.09% <0.00%> (-61.91%) ⬇️
pymc/variational/stein.py 48.33% <0.00%> (-51.67%) ⬇️
pymc/data.py 36.17% <0.00%> (-43.91%) ⬇️
pymc/variational/inference.py 50.77% <0.00%> (-34.20%) ⬇️
... and 11 more

@ricardoV94 ricardoV94 merged commit 44c4983 into pymc-devs:main Nov 29, 2022
@ricardoV94 ricardoV94 deleted the improve_issue_templates branch June 6, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants