Skip to content

ModelGraph only stops ancestry check at model defined named_vars #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

lucianopaz
Copy link
Member

Closes #6421

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ModelGraph.get_parent_names now will only stop at Variable instances whose names are in model.named_vars. Before this, the above mentioned method would return Variable instances with a name that was not None, which could break edges in the returned compute graph.

Documentation

  • ...

Maintenance

  • ...

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #6426 (9fbf0ee) into main (a7f361b) will decrease coverage by 8.68%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6426      +/-   ##
==========================================
- Coverage   94.74%   86.05%   -8.69%     
==========================================
  Files         148      148              
  Lines       27645    27646       +1     
==========================================
- Hits        26193    23792    -2401     
- Misses       1452     3854    +2402     
Impacted Files Coverage Δ
pymc/model_graph.py 80.11% <100.00%> (+0.11%) ⬆️
pymc/tests/logprob/test_utils.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_cumsum.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_mixture.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_abstract.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_rewriting.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_joint_logprob.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_composite_logprob.py 0.00% <0.00%> (-100.00%) ⬇️
pymc/tests/logprob/test_transforms.py 0.00% <0.00%> (-99.74%) ⬇️
pymc/tests/distributions/test_truncated.py 0.00% <0.00%> (-99.49%) ⬇️
... and 16 more

@lucianopaz lucianopaz changed the title ModelGraph only stopsancestry check at model defined named_vars ModelGraph only stops ancestry check at model defined named_vars Jan 3, 2023
@lucianopaz lucianopaz merged commit f6a502a into pymc-devs:main Jan 3, 2023
@lucianopaz lucianopaz deleted the model_graph branch January 3, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: model_to_graphviz nodes become detached if a named node is between two dependent random variables
2 participants