Refactor internal sampling functions #6444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6444 +/- ##
===========================================
- Coverage 85.92% 41.70% -44.22%
===========================================
Files 148 148
Lines 27691 27668 -23
===========================================
- Hits 23794 11540 -12254
- Misses 3897 16128 +12231
|
michaelosthege
force-pushed
the
refactor-sampling-functions
branch
from
356718a to
d39b685
Compare
michaelosthege
force-pushed
the
refactor-sampling-functions
branch
from
52d88e2 to
da79e78
Compare
michaelosthege
force-pushed
the
refactor-sampling-functions
branch
from
da79e78 to
af6a52c
Compare
fonnesbeck
approved these changes
Jan 10, 2023
| sample_args = { | ||
| "draws": draws, | ||
| "step": step, | ||
| "start": initial_points, | ||
| "trace": trace, | ||
| "traces": traces, |
There was a problem hiding this comment.
Is potential breakage worth changing the arg to plural?
There was a problem hiding this comment.
It's a signature change regardless: Optional[BaseTrace] → Sequence[BaseTrace] for multiple functions that this dict is fed to.
All of these are internal API though, so breakage should not be a problem
michaelosthege
force-pushed
the
refactor-sampling-functions
branch
from
ff5a6e9 to
2ab5264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor to simplify signatures of internal sampling functions.
The goal is to avoid returning/yielding
BaseTraceorMultiTraceobjects, making it easier to refactor the trace backend.Checklist
Major / Breaking Changes
pm.iter_samplefunction was removed.Maintenance