Remove add_values/remove_values to fix backend type issues
#6451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values` The `add_values`/`remove_values` methods accessed attributes that are not present on `BaseTrace` but only on `NDarray`, therefore violating the signature.
michaelosthege
added
trace-backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6451 +/- ##
==========================================
+ Coverage 85.97% 94.78% +8.81%
==========================================
Files 148 148
Lines 27731 27678 -53
==========================================
+ Hits 23841 26234 +2393
+ Misses 3890 1444 -2446
|
twiecki
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
add_values/remove_valuesmethods accessed attributes that are not present onBaseTracebut only onNDarray, therefore violating the signature.Checklist
Major / Breaking Changes
MultiTrace.add_values/MultiTrace.remove_valueswere removed.Maintenance
BaseTraceandMultiTracesignatures