Skip to content

Add devcontainer Docker image #6482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jan 26, 2023
Merged

Add devcontainer Docker image #6482

merged 36 commits into from
Jan 26, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 26, 2023

What is this PR about?

Make GitPod (and VS Code) more usable by providing a pre-compiled devcontainer.

Test this via https://gitpod.io/#https://github.com/maresb/pymc

Checklist

Major / Breaking Changes

  • ...

New features

  • Base image from mamba-org/micromamba-devcontainer
  • Performs an editable install of the current pymc and sets up pre-commit hooks
  • Adds a GitHub workflow to generate a new devcontainer image

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • ...

@@ -1,20 +1,39 @@
image: ghcr.io/conda/conda-ci:main-linux-python3.9
image: ghcr.io/maresb/pymc-devcontainer:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a pymc channel here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it needs to exist first. To create it, it should be sufficient to merge this, then run the "create devcontainer" GitHub Action (via the workflow dispatch button). Then we can change the channel here.

But this is only needed when changing the dependencies, so for the moment there is no problem to keep my channel.

@twiecki
Copy link
Member

twiecki commented Jan 26, 2023

Is this done?

@maresb
Copy link
Contributor Author

maresb commented Jan 26, 2023

"Done" is perhaps too generous.

It shouldn't break anything, and it should hopefully move the GitPod situation substantially forward.

I think we can squash-merge, try it out, and fix any problems we experience.

@maresb maresb requested a review from ferrine January 26, 2023 07:36
@twiecki twiecki merged commit 2f6de76 into pymc-devs:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants