Fix some type issues related to retrieving stats from traces #6504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6504 +/- ##
=======================================
Coverage 94.82% 94.83%
=======================================
Files 148 148
Lines 27818 27820 +2
=======================================
+ Hits 26379 26382 +3
+ Misses 1439 1438 -1
|
Armavica
reviewed
Feb 6, 2023
The mcmc module relies on the `"tune"` stat to figure out the number of tune/draw iterations post sampling. These changes remove reliance on any weird squeeze-cat magic. Co-authored-by: Virgile Andreani <[email protected]>
michaelosthege
force-pushed
the
trace-refactoring
branch
from
27ea781 to
7f949ed
Compare
Armavica
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
Statsbijection.rmapcan now take incomplete input dicts.Maintenance
pm.sampleno longer relies onMultiTrace.get_sampler_statsthat does some black magic with the fetched array.