Fix bug in transformed scan variables #6573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Mar 7, 2023
| def scan_step(prev_innov): | ||
| next_innov = at.random.beta(prev_innov * 10, (1 - prev_innov) * 10) | ||
| update = {next_innov.owner.inputs[0]: next_innov.owner.outputs[0]} | ||
| return next_innov, update |
There was a problem hiding this comment.
Adding more (non-probability related) outputs to scan showcases the bug.
Updates are a common output in real scan uses, so this is both more realistic and covers the fixed bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6573 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 91 91
Lines 15108 15108
=======================================
+ Hits 13901 13902 +1
+ Misses 1207 1206 -1
|
twiecki
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would happen when scans have different outputs with mixed transforms (e.g., None and LogOddsTransform), as it was using only the transform of the last variable, due to a typo