Add nuts_sampler_kwargs to pm.sample #6581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6581 +/- ##
==========================================
- Coverage 92.01% 92.00% -0.01%
==========================================
Files 92 92
Lines 15535 15539 +4
==========================================
+ Hits 14294 14297 +3
- Misses 1241 1242 +1
|
ricardoV94
reviewed
Mar 8, 2023
fonnesbeck
changed the title
twiecki
reviewed
Mar 8, 2023
ricardoV94
reviewed
Mar 10, 2023
|
Greatly simplified now. |
twiecki
reviewed
Mar 12, 2023
twiecki
approved these changes
Mar 12, 2023
Apply suggested nuts_sampler_kwarg docstring change Co-authored-by: Thomas Wiecki <[email protected]>
ricardoV94
reviewed
Mar 12, 2023
| import pytest | ||
|
|
||
| from pymc import Model, Normal, sample | ||
|
|
||
| # turns all warnings into errors for this module | ||
| pytestmark = pytest.mark.filterwarnings("error") |
There was a problem hiding this comment.
If a test raises a warning it should be caught explicitly with pytest.warns.
|
pre-commit failed |
|
|
|
Weird, this is what I see here: |
|
Here is the link: https://github.com/pymc-devs/pymc/pull/6581/checks |
|
Oh dang, it was my last-minute edit. |
fonnesbeck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
In the current release, optional parameters for
sample_numpyro_nutswere not making it through when passed frompm.sample:This PR reinstates the
nuts_kwargsargument as a means for getting NUTS arguments to the sampler, and adds asampler_kwargsargument for passing sampler-specific arguments, such as "chain_method" or "postprocessing_backend".Checklist
Major / Breaking Changes
New features
nuts_sampler_kwargsoptional argument topm.sample()to forward kwargs to an external nuts implementation.Bugfixes
Documentation
Maintenance