Skip to content

Infer logp for elemwise transformations of multivariate variables #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ricardoV94
Copy link
Member

Closes #6605

@ricardoV94 ricardoV94 requested a review from ferrine March 17, 2023 16:41
@ricardoV94 ricardoV94 force-pushed the allow_transformation_multivariate branch from 6fe6739 to 7019f4b Compare March 17, 2023 16:44
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #6607 (20104c3) into main (473c952) will decrease coverage by 31.72%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6607       +/-   ##
===========================================
- Coverage   92.01%   60.30%   -31.72%     
===========================================
  Files          93       93               
  Lines       15742    15744        +2     
===========================================
- Hits        14485     9494     -4991     
- Misses       1257     6250     +4993     
Impacted Files Coverage Δ
pymc/logprob/transforms.py 54.48% <0.00%> (-41.66%) ⬇️

... and 69 files with indirect coverage changes

The existing code only considered mixing of scalar and vector transforms, but not potentially higher dimensionality transforms (e.g., matrix)
@ricardoV94 ricardoV94 force-pushed the allow_transformation_multivariate branch from 7019f4b to 20104c3 Compare March 20, 2023 15:46
@ricardoV94 ricardoV94 added the bug label Mar 20, 2023
@ricardoV94 ricardoV94 merged commit f3ce16f into pymc-devs:main Mar 29, 2023
@ricardoV94 ricardoV94 deleted the allow_transformation_multivariate branch June 6, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow inference on transformations of multivariate variables
2 participants