Updating Error message when checking the starting values for MCMC #6632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6632 +/- ##
==========================================
- Coverage 92.02% 90.49% -1.53%
==========================================
Files 93 93
Lines 15752 15752
==========================================
- Hits 14495 14255 -240
- Misses 1257 1497 +240
|
ricardoV94
requested review from
larryshamalama
and removed request for
larryshamalama
larryshamalama
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR aims to solve issue 6629. When we check if the starting values for MCMC do not cause the relevant log probability to evaluate to something invalid and it does, the sampling error currently does not explicitly specify that the initial evaluations correspond to the values of the log-probability at starting values of corresponding parameters. This has created some confusion. In this PR, we specify that the initial evaluations correspond to the logp values.
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance