Rectify type-hints for set_data
#6676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6676 +/- ##
==========================================
- Coverage 92.01% 91.99% -0.02%
==========================================
Files 95 95
Lines 16000 16003 +3
==========================================
Hits 14722 14722
- Misses 1278 1281 +3
|
pymc/model.py
Outdated
| @@ -1155,7 +1155,7 @@ def set_initval(self, rv_var, initval): | |||
| def set_data( | |||
| self, | |||
| name: str, | |||
| values: Dict[str, Optional[Sequence]], | |||
| values: Optional[Sequence], | |||
There was a problem hiding this comment.
Suggested change
| values: Optional[Sequence], | |
| values: Union[Sequence, np.ndarray], |
Dhruvanshu-Joshi
force-pushed
the
dev_typehint
branch
from
62df50a to
95e562c
Compare
michaelosthege
approved these changes
Apr 22, 2023
ricardoV94
changed the title
set_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR aims to solve issue 6667.
Checklist
Major / Breaking Changes
New features
Bugfixes
valuesinmodel.pyis given asDict[str, Optional[Sequence]]. We update it to be anarray-likeobject asSequence.Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6676.org.readthedocs.build/en/6676/