Skip to content

Added scale parameterization to Exponential #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

manulpatel
Copy link
Contributor

@manulpatel manulpatel commented Apr 15, 2023

What is this PR about?
Fixes #6637
Adds alternative scale parametrization to exponential function. scale = 1 / lam

Checklist

Major / Breaking Changes

  • ...

New features

  • Extended functionality of specifing alternative scale parameter in exponential.

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • Relavant test cases added in test_continuous.py.

📚 Documentation preview 📚: https://pymc--6677.org.readthedocs.build/en/6677/

@welcome
Copy link

welcome bot commented Apr 15, 2023

Thank You Banner
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR. I left some comments below

@ricardoV94 ricardoV94 changed the title Added alternative scale parameterization with unit tests to exponential Added scale parameterization to Exponential Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #6677 (2e413cf) into main (fa82fef) will decrease coverage by 11.55%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6677       +/-   ##
===========================================
- Coverage   89.50%   77.95%   -11.55%     
===========================================
  Files          94       95        +1     
  Lines       15942    16009       +67     
===========================================
- Hits        14269    12480     -1789     
- Misses       1673     3529     +1856     
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.72% <100.00%> (+0.01%) ⬆️
pymc/logprob/basic.py 84.74% <100.00%> (-14.41%) ⬇️

... and 58 files with indirect coverage changes

@ricardoV94
Copy link
Member

Thanks @manulpatel, will merge once tests pass

@ricardoV94 ricardoV94 merged commit a617bf2 into pymc-devs:main Apr 28, 2023
@ricardoV94 ricardoV94 changed the title Added scale parameterization to Exponential Added scale parameterization to Exponential May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alternative scale parametrization to Exponential
2 participants