Skip to content

More informative error message for unused step sampler arguments #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2023

Conversation

jahall
Copy link
Contributor

@jahall jahall commented May 26, 2023

More informative error message when passing invalid kwargs to sample

Bugfixes

Closes #6737


📚 Documentation preview 📚: https://pymc--6738.org.readthedocs.build/en/6738/

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@ricardoV94 ricardoV94 changed the title More informative error message in instantiate_steppers More informative error message for unused step sampler arguments Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #6738 (483cd5e) into main (0073639) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6738      +/-   ##
==========================================
- Coverage   91.99%   91.93%   -0.06%     
==========================================
  Files          95       95              
  Lines       16180    16128      -52     
==========================================
- Hits        14885    14828      -57     
- Misses       1295     1300       +5     
Impacted Files Coverage Δ
pymc/sampling/mcmc.py 89.88% <100.00%> (+0.06%) ⬆️
pymc/step_methods/compound.py 97.63% <100.00%> (ø)

... and 25 files with indirect coverage changes

@jahall
Copy link
Contributor Author

jahall commented Jun 7, 2023

@ricardoV94 Fixed mypy issues now...but went down a small rabbit hole to add type hints to assign_step_methods

@jahall jahall marked this pull request as ready for review June 7, 2023 10:23
@jahall jahall requested a review from ricardoV94 June 7, 2023 10:23
@ricardoV94 ricardoV94 merged commit a32c5e7 into pymc-devs:main Jun 7, 2023
@welcome
Copy link

welcome bot commented Jun 7, 2023

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

@jahall jahall deleted the bug-6737 branch June 8, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: max_treedepth argument to pm.sample throws error
2 participants