Skip to content

Fix bug in switch mixture logp #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 9, 2023


📚 Documentation preview 📚: https://pymc--6765.org.readthedocs.build/en/6765/

The True and False branches were being mixed up
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #6765 (2d51d05) into main (261862d) will decrease coverage by 4.33%.
The diff coverage is 88.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6765      +/-   ##
==========================================
- Coverage   91.93%   87.61%   -4.33%     
==========================================
  Files          95       95              
  Lines       16125    16134       +9     
==========================================
- Hits        14825    14136     -689     
- Misses       1300     1998     +698     
Impacted Files Coverage Δ
pymc/logprob/mixture.py 96.33% <ø> (ø)
pymc/logprob/basic.py 96.85% <55.55%> (-3.15%) ⬇️
pymc/logprob/__init__.py 100.00% <100.00%> (ø)
pymc/logprob/scan.py 98.49% <100.00%> (ø)
pymc/model.py 89.91% <100.00%> (ø)
pymc/sampling/mcmc.py 89.88% <100.00%> (+0.06%) ⬆️
pymc/step_methods/compound.py 97.63% <100.00%> (ø)
pymc/testing.py 88.57% <100.00%> (-3.04%) ⬇️

... and 7 files with indirect coverage changes

@ricardoV94 ricardoV94 merged commit 864ecb3 into pymc-devs:main Jun 9, 2023
Copy link
Member

@larryshamalama larryshamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Thanks @ricardoV94

IIRC, I also think that find_measurable_switch_mixture does not broadcast well (the NoneConst should be more general)

@ricardoV94
Copy link
Member Author

Well spotted! Thanks @ricardoV94

IIRC, I also think that find_measurable_switch_mixture does not broadcast well (the NoneConst should be more general)

Yeah. I am pushing a more general solution in the next couple of days, just wanted to get this fixed already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants