Fix compute_test_value error when creating observed variables #6982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed RV in model creation (Fix pymc-devs#6981) - Issue: pymc-devs#6981 - This fix only affects cases with `pytensor.config.compute_test_value!="off"`. Code is not executed otherwise.
|
|
2 tasks
ricardoV94
reviewed
Nov 1, 2023
Should always have the right shape when not None
…e as observed data
There are no cases where the `test_value` should be None, so the code inside that block should not ever be used.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6982 +/- ##
==========================================
+ Coverage 91.70% 92.10% +0.40%
==========================================
Files 100 100
Lines 16899 16894 -5
==========================================
+ Hits 15497 15560 +63
+ Misses 1402 1334 -68
|
ricardoV94
changed the title
pytensor.config.compute_test_value != off
ricardoV94
approved these changes
Nov 2, 2023
|
I pushed a commit that simplifies the test, after confirming it still failed in the main branch. Thanks for the PR. This is the best kind of bug fix :D |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This fixes #6981. The issue was about observed variables causing a
TypeErrorwhen a model is created withpytensor.config.compute_test_value != "off"It adds a small test that reproduces the issue and replacesrv_var.shapebyrv_var.type.shapein thenp.broadcast_to()call.Let me know if I should move the test elsewhere or if something else is needed!
Thanks!
Checklist
Bugfixes
TypeError: Variables do not support boolean operationswithcompute_test_value = "raise"for observed random variable #6981.📚 Documentation preview 📚: https://pymc--6982.org.readthedocs.build/en/6982/