Fix memory leak in logp of transformed variables #6991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
fix_transform_values_new_op
branch
from
ef5cf40 to
431dedb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6991 +/- ##
==========================================
+ Coverage 87.78% 92.18% +4.39%
==========================================
Files 100 101 +1
Lines 16896 16907 +11
==========================================
+ Hits 14832 15585 +753
+ Misses 2064 1322 -742
|
ricardoV94
force-pushed
the
fix_transform_values_new_op
branch
from
431dedb to
519009b
Compare
ricardoV94
force-pushed
the
fix_transform_values_new_op
branch
from
519009b to
48867de
Compare
|
Weird failure on Windows, seems related to the progress_bar. Something akin to: AnswerDotAI/fastprogress#37 https://github.com/pymc-devs/pymc/actions/runs/6772363062/job/18404776473?pr=6991#step:7:197 |
ricardoV94
commented
Nov 7, 2023
| @@ -28,6 +29,8 @@ | |||
| from pymc.smc.kernels import IMH, systematic_resampling | |||
| from tests.helpers import assert_random_state_equal | |||
|
|
|||
| _IS_WINDOWS = platform.system() == "Windows" | |||
There was a problem hiding this comment.
@aloctavodia I had to disable the progressbar on windows. Tests were failing with a cryptic error that I feel is unrelated?
I couldn't get on a Windows machine to reproduce.
twiecki
approved these changes
Nov 8, 2023
ricardoV94
commented
Nov 8, 2023
ricardoV94
commented
Nov 8, 2023
ricardoV94
force-pushed
the
fix_transform_values_new_op
branch
from
9a1c936 to
b487baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6990
First commit is just refactoring, second commit fixes the linked issue
📚 Documentation preview 📚: https://pymc--6991.org.readthedocs.build/en/6991/