Skip to content

Reorganize docs API entries #7030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Reorganize docs API entries #7030

merged 6 commits into from
Nov 29, 2023

Conversation

kataev
Copy link
Contributor

@kataev kataev commented Nov 23, 2023

What is this PR about?
Hello, while making previous PR i found what some modules doesn't import at all:

WARNING: [autosummary] failed to import pymc.constant_fold.
Possible hints:
* AttributeError: module 'pymc' has no attribute 'constant_fold'
* ModuleNotFoundError: No module named 'pymc.constant_fold'
* ImportError:
WARNING: [autosummary] failed to import pymc.math.det.
Possible hints:
* AttributeError: module 'pymc.math' has no attribute 'det'
* ModuleNotFoundError: No module named 'pymc.math.det'; 'pymc.math' is not a package
* ImportError:
WARNING: [autosummary] failed to import pymc.math.extract_diag.
Possible hints:
* ModuleNotFoundError: No module named 'pymc.math.extract_diag'; 'pymc.math' is not a package
* AttributeError: module 'pymc.math' has no attribute 'extract_diag'
* ImportError:
WARNING: [autosummary] failed to import pymc.math.matrix_dot.
Possible hints:
* ModuleNotFoundError: No module named 'pymc.math.matrix_dot'; 'pymc.math' is not a package
* ImportError:
* AttributeError: module 'pymc.math' has no attribute 'matrix_dot'
WARNING: [autosummary] failed to import pymc.math.trace.
Possible hints:
* ImportError:
* AttributeError: module 'pymc.math' has no attribute 'trace'
* ModuleNotFoundError: No module named 'pymc.math.trace'; 'pymc.math' is not a package
WARNING: [autosummary] failed to import pymc.model.core.model_to_networkx.
Possible hints:
* AttributeError: module 'pymc.model.core' has no attribute 'model_to_networkx'
* ModuleNotFoundError: No module named 'pymc.model.core.model_to_networkx'; 'pymc.model.core' is not a package
* ImportError:

Extension error (sphinx.ext.autosummary):

So i am looked in history and found what they removed long ago.

Bugfixes

  • Fixes misspel in import shim around transforms.sum_to_1

Documentation

  • Less errors while docs build

📚 Documentation preview 📚: https://pymc--7030.org.readthedocs.build/en/7030/

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #7030 (4cd807c) into main (ec70d86) will increase coverage by 4.25%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7030      +/-   ##
==========================================
+ Coverage   87.91%   92.16%   +4.25%     
==========================================
  Files         101      101              
  Lines       16849    16827      -22     
==========================================
+ Hits        14812    15509     +697     
+ Misses       2037     1318     -719     
Files Coverage Δ
pymc/distributions/transforms.py 98.48% <100.00%> (+15.90%) ⬆️

... and 7 files with indirect coverage changes

@@ -13,8 +13,6 @@ This submodule contains functions for MCMC and forward sampling.
sample_prior_predictive
sample_posterior_predictive
sample_posterior_predictive_w
sampling.jax.sample_blackjax_nuts
sampling.jax.sample_numpyro_nuts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did these go somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You right, problem was in sampling.jax which doesn't import.
I split tables a little bit.

@twiecki twiecki merged commit 005ba5f into pymc-devs:main Nov 29, 2023
@ricardoV94 ricardoV94 changed the title Another small fixes in docs and imports Reorganize docs API entries Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants