Allow batched scalar sigma in ZeroSumNormal #7063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7063 +/- ##
=======================================
Coverage 92.19% 92.20%
=======================================
Files 101 101
Lines 16893 16895 +2
=======================================
+ Hits 15575 15578 +3
+ Misses 1318 1317 -1
|
lucianopaz
approved these changes
Dec 13, 2023
| @@ -2706,7 +2702,12 @@ def check_zerosum_axes(cls, n_zerosum_axes: Optional[int]) -> int: | |||
|
|
|||
| @classmethod | |||
| def rv_op(cls, sigma, n_zerosum_axes, support_shape, size=None): | |||
| shape = to_tuple(size) + tuple(support_shape) | |||
| if size is not None: | |||
| shape = tuple(size) + tuple(support_shape) | |||
There was a problem hiding this comment.
Do we need to check that size and sigma.shape are compatible or that done somewhere else before this call?
There was a problem hiding this comment.
We shouldn't have to check. Shape issues will arise when creating Normal below or at evaluation time when broadcasting fails between size and sigma
ricardoV94
force-pushed
the
fix_batched_sigma_zsn
branch
from
705fb55 to
9477d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The check that existed before was meant to prevent non-scalar sigma across zero-sum axes, but there is no reason to prevent it across batch dimensions.
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7063.org.readthedocs.build/en/7063/