Skip to content

Add option to save model graph to an image #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

aloctavodia
Copy link
Member

@aloctavodia aloctavodia commented Feb 16, 2024


📚 Documentation preview 📚: https://pymc--7158.org.readthedocs.build/en/7158/

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0d8ddba) 92.35% compared to head (a1eaf5e) 92.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7158      +/-   ##
==========================================
- Coverage   92.35%   92.30%   -0.05%     
==========================================
  Files         101      101              
  Lines       16944    16955      +11     
==========================================
+ Hits        15648    15650       +2     
- Misses       1296     1305       +9     
Files Coverage Δ
pymc/model/core.py 92.22% <100.00%> (ø)
pymc/model_graph.py 77.38% <30.76%> (-3.47%) ⬇️

@@ -307,6 +309,11 @@ def test_model_to_graphviz_for_model_with_data_container(self):
for expected in expected_substrings:
assert expected in g.source

pm.model_to_graphviz(model, save="model.png")
assert path.exists("model.png")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to create permanent files during tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardoV94 ricardoV94 changed the title add option to save graph to an image Add option to save graph to an image Feb 17, 2024
@ricardoV94 ricardoV94 changed the title Add option to save graph to an image Add option to save model graph to an image Feb 17, 2024
@ricardoV94 ricardoV94 merged commit c3e0d86 into pymc-devs:main Feb 17, 2024
@aloctavodia aloctavodia deleted the graph_save branch February 17, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants