-
Notifications
You must be signed in to change notification settings - Fork 135
Add Ops for LU Factorization #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jessegrabowski
merged 4 commits into
pymc-devs:main
from
jessegrabowski:LU-factorization
Apr 19, 2025
Merged
Add Ops for LU Factorization #1218
jessegrabowski
merged 4 commits into
pymc-devs:main
from
jessegrabowski:LU-factorization
Apr 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ceece7
to
e57bf39
Compare
b1f8c9d
to
2a5b361
Compare
2a5b361
to
93314a5
Compare
ricardoV94
reviewed
Feb 28, 2025
Any benchmarks on solve written with these Ops? |
Working on that next, just ironing out some bugs in the |
a03bcce
to
b7aa9f8
Compare
191b755
to
3650e99
Compare
bfa93aa
to
c89cbd5
Compare
b4ac1f6
to
8928390
Compare
a3ea772
to
d648a15
Compare
ricardoV94
approved these changes
Apr 19, 2025
6a245ab
to
8e8311e
Compare
9f33f9e
to
1e42069
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
+ Coverage 82.05% 82.07% +0.02%
==========================================
Files 203 206 +3
Lines 48863 49174 +311
Branches 8695 8720 +25
==========================================
+ Hits 40093 40359 +266
- Misses 6619 6656 +37
- Partials 2151 2159 +8
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add the following Ops:
As well as dispatches for numba/jax (and maybe torch, though help is welcome there).
The reason for wanting these is that it will make the gradients of solve faster. I think this is a major reason why jax has faster gradients than us (at least when solve is implicated). They route everything to
lu_solve(lu_factor(A), b)
, and reuselu_factor(A)
in the backward pass.Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1218.org.readthedocs.build/en/1218/