Skip to content

Fixed the get_var func #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pytensor/graph/basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -2032,7 +2032,7 @@ def compare_nodes(nd_x, nd_y, common, different):


def get_var_by_name(
graphs: Iterable[Variable], target_var_id: str, ids: str = "CHAR"
graphs: Iterable[Variable], target_var_id: str, include_inner_graphs: bool = False
) -> tuple[Variable, ...]:
r"""Get variables in a graph using their names.

Expand All @@ -2057,7 +2057,7 @@ def expand(r) -> list[Variable] | None:

res = list(r.owner.inputs)

if isinstance(r.owner.op, HasInnerGraph):
if include_inner_graphs and isinstance(r.owner.op, HasInnerGraph):
res.extend(r.owner.op.inner_outputs)

return res
Expand Down
25 changes: 25 additions & 0 deletions tests/graph/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,31 @@ def test_get_var_by_name():
assert res == exp_res


def test_get_var_by_name_include_inner_graphs_flag():
r1, r2, r3 = MyVariable(1), MyVariable(2), MyVariable(3)
o1 = MyOp(r1, r2)
o1.name = "o1"

# Inner graph
igo_in_1 = MyVariable(4)
igo_in_2 = MyVariable(5)
igo_out_1 = MyOp(igo_in_1, igo_in_2)
igo_out_1.name = "igo1"

igo = MyInnerGraphOp([igo_in_1, igo_in_2], [igo_out_1])
o2 = igo(r3, o1)

res = get_var_by_name([o1, o2], "igo1", include_inner_graphs=False)
assert (
res == ()
), "Should not return inner graph variable when include_inner_graphs is False"

res = get_var_by_name([o1, o2], "igo1", include_inner_graphs=True)
assert any(
v.name == "igo1" for v in res
), "Should return inner graph variable when include_inner_graphs is True"


def test_clone_new_inputs():
"""Make sure that `Apply.clone_with_new_inputs` properly handles `Type` changes."""

Expand Down
Loading