Skip to content

Fix invalid numpy dtype #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 9, 2025

There were some bugs that survived along time, until numpy 2.3.0 where it finally fails.

first showed up in #1182


📚 Documentation preview 📚: https://pytensor--1456.org.readthedocs.build/en/1456/

@ricardoV94 ricardoV94 requested a review from jessegrabowski June 9, 2025 12:34
@ricardoV94 ricardoV94 added the bug Something isn't working label Jun 9, 2025
@ricardoV94 ricardoV94 force-pushed the fix_zero_grad_bug branch from 5417a3c to c32b034 Compare June 9, 2025 13:04
@ricardoV94 ricardoV94 changed the title Fix bug in ZeroGrad Fix invalid numpy dtype Jun 9, 2025
@ricardoV94 ricardoV94 force-pushed the fix_zero_grad_bug branch from c32b034 to 0efe70b Compare June 9, 2025 13:42
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (0ea61bc) to head (0efe70b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1456   +/-   ##
=======================================
  Coverage   82.12%   82.12%           
=======================================
  Files         211      211           
  Lines       49757    49757           
  Branches     8819     8819           
=======================================
  Hits        40862    40862           
  Misses       6715     6715           
  Partials     2180     2180           
Files with missing lines Coverage Δ
pytensor/gradient.py 78.55% <100.00%> (ø)
pytensor/scalar/basic.py 80.56% <100.00%> (ø)
pytensor/sparse/rewriting.py 76.15% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jessegrabowski jessegrabowski merged commit d10f245 into pymc-devs:main Jun 9, 2025
73 checks passed
@ricardoV94 ricardoV94 deleted the fix_zero_grad_bug branch June 9, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants