-
Notifications
You must be signed in to change notification settings - Fork 77
Add experiment design notation docs page to new Knowledge Base section of the docs #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 21 21
Lines 1380 1380
=======================================
Hits 1064 1064
Misses 316 316 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. Let mw know what you think. I think it would bring a lot of clarity to use the potential outcomes language (just a suggestion)
It would also be nice to indicate briefly after eash method how this could be done in CausalPy. I think it would be a great entrypoint for the library.
Failing doctest seems to be some broken import in arviz, nothing internal to causalpy. |
Thanks for the review. It's just my edit to the ANCOVA/covariate(s) which might need to be looked at I think. For the moment I'm trying to steer clear of mentioning the potential outcomes framework, or talk about DAGS and backdoors etc. My rough goal here is to create a series of relatively self-contained knowledge base pages which are relatively focussed. So this docs page is intended to focus on the experiment design side of things, but there will be another docs page focussing on DAGS for the different quasi-experimental designs, and maybe others on the potential outcomes framework or g-computation. Similarly, I'm trying to keep some separation between the theory (in the knowledge base) and practice (in the example notebooks). It might not always be like that, but at the moment that seems like the right structure to tackle things in relatively bite-sized chunks |
Got it! Thanks for providing context! |
BTW: The test is failing because of pymc-labs/pymc-marketing#608. An |
Remote tests still failing despite there being an arviz release (https://github.com/arviz-devs/arviz/releases/tag/v0.18.0) 12 hours ago |
Knowledge Base