Skip to content

Setup initial codeowners #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Setup initial codeowners #244

merged 1 commit into from
Jan 9, 2022

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Jan 9, 2022

Andrew Svetlov, Michael Seifert, and Tin Tvrtković are added as reviewers for all pull requests.

Andrew Svetlov, Michael Seifert, and Tin Tvrtković are added as reviewers for all pull requests
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022

Codecov Report

Merging #244 (75a26ac) into master (47ae437) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files           2        2           
  Lines         227      227           
=======================================
  Hits          217      217           
  Misses         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ae437...75a26ac. Read the comment docs.

@asvetlov
Copy link
Contributor Author

asvetlov commented Jan 9, 2022

@Tinche @seifertm I believe this simple trick can help with cross-review, the review request is more visible if you use some sort of GitHub notifications.

The reviewer assignment is a suggestion, not a blocker. It doesn't hurt.

@asvetlov asvetlov merged commit 4176c3d into master Jan 9, 2022
@asvetlov asvetlov deleted the codeowners branch January 9, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants