warn specific classes #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
warn-specific-warn-classes
branch
4 times, most recently
from
fe580ae to
56b0cfb
Compare
graingert
commented
Nov 19, 2019
ionelmc
force-pushed
the
warn-specific-warn-classes
branch
from
56b0cfb to
1734d2d
Compare
|
So I took the liberty of rebasing - master has the CI fixed now. |
graingert
commented
Jul 20, 2021
graingert
commented
Jul 20, 2021
graingert
commented
Jul 20, 2021
graingert
commented
Jul 20, 2021
graingert
commented
Jul 20, 2021
graingert
commented
Jul 20, 2021
|
Seems simple enough, tests pass, I guess we'll see if we break weird warning filters on the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.