Unblock DB in case of error for reports #778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly works around pytest causing an INTERNALERROR for when using `repr()` on the `pytest.fail.Exception` that is used when the DB is blocked. While this will be fixed via pytest-dev/pytest#6047 likely, it might be good to have this anyway (also for older pytest versions). On the other hand this might cause the DB to be accessed/changed then, which might show different results from when the test failed due to this?! Fixes pytest-dev#713. Fixes pytest-dev#341.
|
Going with #781 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly works around pytest causing an INTERNALERROR for when using
repr()on thepytest.fail.Exceptionthat is used when the DB isblocked.
While this will be fixed via
pytest-dev/pytest#6047 likely, it might be good
to have this anyway (also for older pytest versions).
On the other hand this might cause the DB to be accessed/changed then,
which might show different results from when the test failed due to
this?!
Fixes #713.
Fixes #341.