FIX use safe_getattr instead of getattr for Python 3.9 compat

AUTHORS

@@ -164,6 +164,7 @@ Gregory Lee
 Grig Gheorghiu
 Grigorii Eremeev (budulianin)
 Guido Wesdorp
+Guillaume Lemaitre
 Guoqiang Zhang
 Harald Armin Massa
 Harshna

changelog/11872.bugfix.rst

@@ -0,0 +1 @@
+Correctly handle `HTTPError` in :func:`pytest.raises` for Python <= 3.9.

src/_pytest/_code/code.py

@@ -47,6 +47,7 @@
 from _pytest._io.saferepr import safeformat
 from _pytest._io.saferepr import saferepr
 from _pytest.compat import get_real_func
+from _pytest.compat import safe_getattr
 from _pytest.deprecated import check_ispytest
 from _pytest.pathlib import absolutepath
 from _pytest.pathlib import bestrelpath
@@ -702,7 +703,7 @@ def _stringify_exception(self, exc: BaseException) -> str:
         return "\n".join(
             [
                 str(exc),
-                *getattr(exc, "__notes__", []),
+                *safe_getattr(exc, "__notes__", []),
             ]
         )
 

testing/code/test_excinfo.py

@@ -11,6 +11,7 @@
 from pathlib import Path
 from typing import Any
 from typing import TYPE_CHECKING
+from urllib.error import HTTPError
 
 import _pytest._code
 import pytest
@@ -1790,3 +1791,14 @@ def test_check_error_notes_failure(
     with pytest.raises(AssertionError):
         with pytest.raises(type(error), match=match):
             raise error
+
+
+def test_notes_getattr_keyerror():
+    """Non-regression test for #11872.
+
+    HTTPError in Python < 3.10 was subclassing tempfile._TemporaryFileWrapper that
+    was not properly initialize and not exposing a `__file__` attribute:
+    https://github.com/python/cpython/issues/98778
+    """
+    with pytest.raises(HTTPError, match="Not Found"):
+        raise HTTPError(code=404, msg="Not Found", fp=None, hdrs=None, url="")