-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[pre-commit.ci] pre-commit autoupdate #12741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.1 → v0.6.2](astral-sh/ruff-pre-commit@v0.6.1...v0.6.2) - [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2)
8e2f001
to
8e86ac5
Compare
@nicoddemus I fixed readthedoc by changing your temporary fix to something that is going to work if new versions of towncrier are released without sphinx-contrib/sphinxcontrib-towncrier#92 being resolved (8e86ac5), I'll let you review this part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks @Pierre-Sassoulas
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.1 → v0.6.2](astral-sh/ruff-pre-commit@v0.6.1...v0.6.2) - [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2) * Fix sphinx with a more robust fix Until sphinx-contrib/sphinxcontrib-towncrier#92 is resolved. Co-authored-by: Pierre Sassoulas <[email protected]>
@@ -3,4 +3,4 @@ | |||
|
|||
# Pin towncrier temporarily due to incompatibility with sphinxcontrib-towncrier: | |||
# https://github.com/sphinx-contrib/sphinxcontrib-towncrier/issues/92 | |||
towncrier!=24.7.0,!=24.7.1 | |||
towncrier<24.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pierre-Sassoulas I wanted to revert the PR, but it contains more things than this line… FYI, the extension is now compatible with new Towncrier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be only 2 conflicts during the revert and we can keep the line with the higher value each time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it's probably better to start from scratch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was just being lazy in the middle of the night :) So I figured I'd at least leave a notification in here.
updates: