logging: reuse LoggingCaptureHandler instance since it's expensive to create #7227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a LoggingCaptureHandler was instantiated for each test's setup/call/teardown which turns out to be expensive.
Instead, only keep one instance and reset it between runs.
(Previously in #7214. Now I'm pretty sure it will interact well with the other PRs).
Benchmark
Before:
After: