Fix typos #1346
Closed
Fix typos #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianmeng
requested review from
tleonhardt,
kotfu,
kmvanbrunt and
anselor
as code owners
tleonhardt
requested changes
Oct 23, 2024
| @@ -153,7 +153,7 @@ Projects using cmd2 | |||
| | [Poseidon](https://github.com/CyberReboot/poseidon) | Leverages software-defined networks (SDNs) to acquire and then feed network traffic to a number of machine learning techniques. | | | |||
| | [Unipacker](https://github.com/unipacker/unipacker) | Automatic and platform-independent unpacker for Windows binaries based on emulation | | | |||
| | [tomcatmanager](https://github.com/tomcatmanager/tomcatmanager) | A command line tool and python library for managing a tomcat server | | | |||
| | [Expliot](https://gitlab.com/expliot_framework/expliot) | Internet of Things (IoT) exploitation framework | | | |||
There was a problem hiding this comment.
This is the name of the package and not a typo
| @@ -5,7 +5,7 @@ Application Name, Description | |||
| [Poseidon](https://github.com/CyberReboot/poseidon),Leverages software-defined networks (SDNs) to acquire and then feed network traffic to a number of machine learning techniques. | |||
| [Unipacker](https://github.com/unipacker/unipacker),Automatic and platform-independent unpacker for Windows binaries based on emulation | |||
| [tomcatmanager](https://github.com/tomcatmanager/tomcatmanager),A command line tool and python library for managing a tomcat server | |||
| [Expliot](https://gitlab.com/expliot_framework/expliot),Internet of Things (IoT) exploitation framework | |||
| [Exploit](https://gitlab.com/expliot_framework/expliot),Internet of Things (IoT) exploitation framework | |||
There was a problem hiding this comment.
Same name of package not a typo
| @@ -6,10 +6,10 @@ Genre: | |||
|
|
|||
|
|
|||
|
|
|||
| Name: Microsoft/ Azure Counterfit | |||
| Name: Microsoft/ Azure Counterfeit | |||
kmvanbrunt
requested changes
Oct 23, 2024
| @@ -153,7 +153,7 @@ Projects using cmd2 | |||
| | [Poseidon](https://github.com/CyberReboot/poseidon) | Leverages software-defined networks (SDNs) to acquire and then feed network traffic to a number of machine learning techniques. | | | |||
| | [Unipacker](https://github.com/unipacker/unipacker) | Automatic and platform-independent unpacker for Windows binaries based on emulation | | | |||
| | [tomcatmanager](https://github.com/tomcatmanager/tomcatmanager) | A command line tool and python library for managing a tomcat server | | | |||
| | [Expliot](https://gitlab.com/expliot_framework/expliot) | Internet of Things (IoT) exploitation framework | | | |||
| | [Exploit](https://gitlab.com/expliot_framework/expliot) | Internet of Things (IoT) exploitation framework | | | |||
There was a problem hiding this comment.
"Expliot" is the name of the software. It's not a typo.
| @@ -5,7 +5,7 @@ Application Name, Description | |||
| [Poseidon](https://github.com/CyberReboot/poseidon),Leverages software-defined networks (SDNs) to acquire and then feed network traffic to a number of machine learning techniques. | |||
| [Unipacker](https://github.com/unipacker/unipacker),Automatic and platform-independent unpacker for Windows binaries based on emulation | |||
| [tomcatmanager](https://github.com/tomcatmanager/tomcatmanager),A command line tool and python library for managing a tomcat server | |||
| [Expliot](https://gitlab.com/expliot_framework/expliot),Internet of Things (IoT) exploitation framework | |||
| [Exploit](https://gitlab.com/expliot_framework/expliot),Internet of Things (IoT) exploitation framework | |||
There was a problem hiding this comment.
"Expliot" is the name of the software. It's not a typo.
| @@ -6,10 +6,10 @@ Genre: | |||
|
|
|||
|
|
|||
|
|
|||
| Name: Microsoft/ Azure Counterfit | |||
| Name: Microsoft/ Azure Counterfeit | |||
There was a problem hiding this comment.
"Azure Counterfit" is the name of the software. It's not a typo.
| Source Code: https://github.com/Azure/counterfit | ||
| Status: Active | ||
| Description: Counterfit is a command-line tool and generic automation layer for assessing the security of machine learning systems. | ||
| Description: Counterfeit is a command-line tool and generic automation layer for assessing the security of machine learning systems. |
There was a problem hiding this comment.
"Azure Counterfit" is the name of the software. It's not a typo.
| @@ -876,16 +876,16 @@ def test_find_editor_not_specified(): | |||
|
|
|||
|
|
|||
| def test_similarity(): | |||
| suggested_command = cu.suggest_similar("comand", ["command", "UNRELATED", "NOT_SIMILAR"]) | |||
| suggested_command = cu.suggest_similar("command", ["command", "UNRELATED", "NOT_SIMILAR"]) | |||
There was a problem hiding this comment.
This unit test requires "command" to be misspelled. It's not a typo.
| assert suggested_command == "command" | ||
| suggested_command = cu.suggest_similar("command", ["COMMAND", "acommands"]) | ||
| assert suggested_command == "COMMAND" | ||
|
|
||
|
|
||
| def test_similarity_without_good_canididates(): | ||
| suggested_command = cu.suggest_similar("comand", ["UNRELATED", "NOT_SIMILAR"]) | ||
| suggested_command = cu.suggest_similar("command", ["UNRELATED", "NOT_SIMILAR"]) |
There was a problem hiding this comment.
This unit test requires "command" to be misspelled. It's not a typo.
| assert suggested_command is None | ||
| suggested_command = cu.suggest_similar("comand", []) | ||
| suggested_command = cu.suggest_similar("command", []) |
There was a problem hiding this comment.
This unit test requires "command" to be misspelled. It's not a typo.
|
@kianmeng Thanks for this PR. We appreciate the typos you fixed. If you can address comments from the two of us to fix the things which actually are not typos, we would be happy to merge this in. Thanks again! |
|
Closing since I'm doing this in another branch. |
Merged
|
@tleonhardt @kmvanbrunt Sorry guys, just saw your messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -L te,counterfit,afileandtypos --hidden --format brief