Fix _SWITCH_UPGRADE without proposal error message #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to switch protocols when the client has not requested it, h11 throws a
LocalProtocolError
.Here is how h11 do it:
h11/h11/_state.py
Lines 284 to 289 in a2c6894
However, this exception can only be raised when the event is
_SWITCH_UPGRADE
, because another scenario was already checked here:h11/h11/_connection.py
Lines 263 to 268 in a2c6894
In other words, if the server_switch_event is _SWITCH_CONNECT, we always know that such an event is being proposed.