Skip to content

Add default mypy config file reference #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add default mypy config file reference #20

wants to merge 1 commit into from

Conversation

hirosassa
Copy link

@hirosassa hirosassa commented Oct 2, 2021 •
edited
Loading

What is this PR?

This PR added the feature that pylsp-mypy refers mypy's default config files when there's no config file in the current project.

Reference: https://mypy.readthedocs.io/en/stable/config_file.html

@hirosassa hirosassa changed the title Add default mypy config file feature Add default mypy config file reference Oct 2, 2021
@hirosassa
Copy link
Author

hirosassa commented Oct 9, 2021 •
edited
Loading

@Richardk2n
Hi! Cloud you please review this PR? This implementation looks working well in my local env.
If I miss anything, please let me know. Thank you!

@Richardk2n
Copy link
Member

How urgent is this? I'd like to change the config system somewhat and therefore would like to pay close attention when reviewing, therefore this might take some time. However I am currently writing my master thesis (will be finished in 1 to 1.5 month) and if you would agree, that this PR is not too urgent, i would review that afterwards.

@hirosassa
Copy link
Author

I am currently writing my master thesis

Oh sorry, this is not urgent. Your thesis is more and more important than this PR. Please concentrate on it and I hope your defense go well 👍

@Richardk2n Richardk2n force-pushed the master branch 2 times, most recently from 48075b6 to 788c75a Compare December 19, 2021 18:16
Richardk2n added a commit that referenced this pull request Dec 17, 2022
@Richardk2n
addresses #20
a4e3750
@Richardk2n
Copy link
Member

Sorry I left you hanging for so extremely long. I implemented this somewhat differently (to preserve search order). Does this implementation fulfill your needs?

@hirosassa
Copy link
Author

@Richardk2n Thank you for your comment! I'll check it.

@Richardk2n
Copy link
Member

Closing for housekeeping reasons.
Should the changes not be sufficient, feel free to remind me.

@Richardk2n Richardk2n closed this Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hirosassa @Richardk2n